-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script to combine 7m and TP cubes #340
base: main
Are you sure you want to change the base?
Conversation
This script does feather and mosaic cubes of 7m and TP data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few small suggestions
aces/imaging/TP-ACA-feather.py
Outdated
templateIM='CS2-1-temlate-whole-band.image' | ||
|
||
import glob | ||
linename=glob.glob('*.image.pbcor') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this to
linename=glob.glob('*.image.pbcor') | |
linename=glob.glob('*spw33*.image.pbcor') |
so that, if you run it in a directory with other cubes in it by accident, you don't change their header frequency value unintentionally
|
||
daca={} | ||
dtp={} | ||
with open("dict-aca.txt") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add this file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's added in #342
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments. I have edited the script accordingly (I think I dit it). Which bottom should I click to submit this change request so you could merge it?
linename=glob.glob('*.image.pbcor')
linename=glob.glob('spw33.image.pbcor')
@pyhsiehATalma Please check my suggestions and try to fix the style issues so we can merge this. |
changing line name from linename=glob.glob('*.image.pbcor') to linename=glob.glob('*spw33*.image.pbcor')
Add a line in tox.ini to ignore all the warnings shown here: see https://github.com/ACES-CMZ/reduction_ACES/blob/main/tox.ini#L106 for an example |
This script does feather and mosaic cubes of 7m and TP data.